Conversation
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
Contributor
UI Previewmici: |
adeebshihadeh
added a commit
that referenced
this pull request
May 10, 2026
This reverts commit 5745909.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #37980
plannerd and radard timings becoming less consistent when bumped below ui makes sense, but no clue why they recover. Then modeld becomes noisy and then drops to a new floor?! This may be the random noise I've been trying to unsuccessfully figure out for the past few days. Regardless, this is a huge improvement for ui frame drops
@adeebshihadeh if you have time and want to see if it can be made consistent, just run openpilot with CAN replay onroad, make sure you patch ui_state.py so it thinks it's engaged.
Weird, I swapped ui back to 51 and plannerd and radard got noisy, so doesn't look like ui above them inherently destroys timings: