Skip to content

Add MISRA check for integer bool literals#2405

Closed
dhrubasumatary wants to merge 1 commit into
commaai:masterfrom
dhrubasumatary:fix-bool-literal-misra
Closed

Add MISRA check for integer bool literals#2405
dhrubasumatary wants to merge 1 commit into
commaai:masterfrom
dhrubasumatary:fix-bool-literal-misra

Conversation

@dhrubasumatary

Copy link
Copy Markdown

Summary

  • add a cppcheck addon to report integer 0/1 literals assigned to bools
  • run the addon with the existing MISRA check
  • fix existing Panda bool literal assignments and add a mutation case

Verification

  • tests/misra/test_misra.sh
  • pytest -q tests/misra/test_mutation.py

@adeebshihadeh

Copy link
Copy Markdown
Contributor

Closing in favor of #2409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants