Skip to content

fix: use false/true instead of 0/1 for bool assignments (MISRA 10.3) #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
theherrovn-sys wants to merge 1 commit into from
+5 −2
Closed

fix: use false/true instead of 0/1 for bool assignments (MISRA 10.3) #2407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions board/drivers/can_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ can_ring *can_queues[PANDA_CAN_CNT] = {&can_tx1_q, &can_tx2_q, &can_tx3_q};

// ********************* interrupt safe queue *********************
bool can_pop(can_ring *q, CANPacket_t *elem) {
bool ret = 0;
bool ret = false;

ENTER_CRITICAL();
if (q->w_ptr != q->r_ptr) {
Expand All @@ -48,7 +48,7 @@ bool can_pop(can_ring *q, CANPacket_t *elem) {
} else {
q->r_ptr += 1U;
}
ret = 1;
ret = true;
}
EXIT_CRITICAL();

Expand Down
3 changes: 3 additions & 0 deletions tests/misra/suppressions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,6 @@ unusedFunction:*/interrupt_handlers*.h
# cppcheck from 2.5 -> 2.13. they are listed here to separate the update from
# fixing the violations and all are intended to be removed soon after
misra-c2012-2.5 # unused macros. a few legit, rest aren't common between F4/H7 builds. should we do this in the unusedFunction pass?

# TODO: remove after opendbc PR #3256 or equivalent is merged
misra-c2012-10.3:*/opendbc/safety/modes/toyota.h
Loading