Conversation
A new job builds plphp.so and jsonb_plphp.so with -fsanitize=address (via a new ASAN_FLAGS hook in the Makefiles) and runs the regression suite against a PostgreSQL 18 server started with libasan preloaded, so use-after-free and out-of-bounds bugs of the kind fixed in the per-function-context work are caught mechanically on every PR. PHP dlopens its shared extensions with RTLD_DEEPBIND, which the sanitizer runtime refuses, so the server runs with PHP_INI_SCAN_DIR empty (no shared extensions) and the cookbook test -- whose XML recipe needs SimpleXML -- is skipped in this job only. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a 12th CI job: build with
-fsanitize=address(newASAN_FLAGSMakefile hook), preloadlibasaninto a PG 18 server, run the full suite. The memory-safety class we fixed by inspection in #22/#23 now gets caught mechanically on every PR.Wrinkle discovered en route: PHP dlopens its shared extensions with
RTLD_DEEPBIND, which ASAN's runtime refuses (sanitizers issue #611) — the job therefore runs the server withPHP_INI_SCAN_DIR=(no shared extensions) and skips only the cookbook test (its XML recipe needs SimpleXML). Validated locally: 22/22 core +jsonb_plphpunder ASAN, zero reports.🤖 Generated with Claude Code