Skip to content

Improve dropdown font & spacings #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pfferrari merged 1 commit into from
Apr 10, 2026
+11 −11
Merged

Improve dropdown font & spacings #1072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/app-elements/src/ui/composite/Dropdown/DropdownItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ export const DropdownItem = withSkeletonTemplate<DropdownItemProps>(
}}
href={href}
className={cn(
"w-[calc(100%-1rem)] bg-white text-black! py-1.5 pl-4 mx-2 text-sm font-regular flex items-center focus:outline-hidden!",
"w-[calc(100%-1rem)] bg-white text-black! py-1.5 pl-2.5 mx-2 text-sm font-medium flex items-center focus:outline-hidden!",
{
"pr-8": info == null,
"min-w-[250px] pr-6": info != null,
"min-w-64 pr-6": info != null,
},
className,
{
Expand Down Expand Up @@ -93,7 +93,7 @@ export const DropdownItem = withSkeletonTemplate<DropdownItemProps>(
{label}
</span>
{info != null && (
<span className="ml-auto pl-1 text-xs text-gray-500 font-semibold group-hover:text-white">
<span className="ml-auto pl-1 text-xs text-gray-500 font-semibold group-hover:text-gray-600">
{info}
</span>
)}
Expand Down
2 changes: 1 addition & 1 deletion packages/app-elements/src/ui/composite/Dropdown/DropdownMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export const DropdownMenu: FC<DropdownMenuProps> = ({
className={cn(
"bg-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 border shadow-lg",
{
"min-w-[150px] md:max-w-[250px]": menuWidth == null, // default width
"min-w-40 md:max-w-80": menuWidth == null, // default width
"w-70": menuWidth === "wide",
},
)}
Expand Down
14 changes: 7 additions & 7 deletions packages/app-elements/src/ui/composite/Dropdown/__snapshots__/Dropdown.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ exports[`Dropdown > Should be rendering bottom-left 1`] = `
class="flex flex-col items-start"
>
<div
class="bg-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 border shadow-lg min-w-[150px] md:max-w-[250px]"
class="bg-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 border shadow-lg min-w-40 md:max-w-80"
>
<div />
</div>
Expand Down Expand Up @@ -72,7 +72,7 @@ exports[`Dropdown > Should be rendering top-left 1`] = `
class="flex flex-col-reverse items-start"
>
<div
class="bg-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 border shadow-lg min-w-[150px] md:max-w-[250px]"
class="bg-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 border shadow-lg min-w-40 md:max-w-80"
>
<div />
</div>
Expand Down Expand Up @@ -113,7 +113,7 @@ exports[`Dropdown > Should be rendering top-right 1`] = `
class="flex flex-col-reverse items-end"
>
<div
class="bg-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 border shadow-lg min-w-[150px] md:max-w-[250px]"
class="bg-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 border shadow-lg min-w-40 md:max-w-80"
>
<div />
</div>
Expand Down Expand Up @@ -154,11 +154,11 @@ exports[`Dropdown > Should be rendering with default bottom-right position 1`] =
class="flex flex-col items-end"
>
<div
class="bg-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 border shadow-lg min-w-[150px] md:max-w-[250px]"
class="bg-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 border shadow-lg min-w-40 md:max-w-80"
>
<button
aria-label="Payments"
class="w-[calc(100%-1rem)] bg-white text-black! py-1.5 pl-4 mx-2 text-sm font-regular flex items-center focus:outline-hidden! pr-8 hover:bg-gray-100 hover:rounded cursor-pointer focus:bg-gray-100 group"
class="w-[calc(100%-1rem)] bg-white text-black! py-1.5 pl-2.5 mx-2 text-sm font-medium flex items-center focus:outline-hidden! pr-8 hover:bg-gray-100 hover:rounded cursor-pointer focus:bg-gray-100 group"
>
<div
class="mr-2"
Expand All @@ -184,7 +184,7 @@ exports[`Dropdown > Should be rendering with default bottom-right position 1`] =
</button>
<button
aria-label="Items"
class="w-[calc(100%-1rem)] bg-white text-black! py-1.5 pl-4 mx-2 text-sm font-regular flex items-center focus:outline-hidden! pr-8 hover:bg-gray-100 hover:rounded cursor-pointer focus:bg-gray-100 group"
class="w-[calc(100%-1rem)] bg-white text-black! py-1.5 pl-2.5 mx-2 text-sm font-medium flex items-center focus:outline-hidden! pr-8 hover:bg-gray-100 hover:rounded cursor-pointer focus:bg-gray-100 group"
>
<div
class="mr-2"
Expand All @@ -209,7 +209,7 @@ exports[`Dropdown > Should be rendering with default bottom-right position 1`] =
</div>
<button
aria-label="Delete"
class="w-[calc(100%-1rem)] bg-white text-black! py-1.5 pl-4 mx-2 text-sm font-regular flex items-center focus:outline-hidden! pr-8 hover:bg-gray-100 hover:rounded cursor-pointer focus:bg-gray-100 group"
class="w-[calc(100%-1rem)] bg-white text-black! py-1.5 pl-2.5 mx-2 text-sm font-medium flex items-center focus:outline-hidden! pr-8 hover:bg-gray-100 hover:rounded cursor-pointer focus:bg-gray-100 group"
>
<div
class="mr-2"
Expand Down
Loading