🐛 fix(HostedCart): refresh minicart URL when persistKey changes — v5 port (#740)#741
Merged
🐛 fix(HostedCart): refresh minicart URL when persistKey changes — v5 port (#740)#741
Conversation
… and fix useEffect deps
…n-config Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Port of PR #740 onto the
v5.0.0branch.🐛 Fix:
HostedCart— refresh minicart URL whenpersistKeychanges (Closes #685)loadedOrderIdRefto track which order ID the currentsrcwas built forpersistKeytouseEffectdependency array so the cart URL recomputes when the storage key changessetOrderorg-config lookup to useorder?.id ?? orderIdconsistentlyspecs/orders/hosted-cart.spec.tsx📦 Deps: bump
@commercelayer/organization-configto^2.8.4ConfigParamsfields:identityType,clientId,scope,returnUrl,resetPasswordUrl,skuListId,skuId,lang,token✨ Feat:
MyIdentityLink— pass all identity params togetOrganizationConfigidentityType,clientId,scope,returnUrl,resetPasswordUrlgetDomain(endpoint)inside theuseEffectcallback to keep deps cleanuseEffectdependency array to include all consumed props✨ Feat:
AddToCartButton— passskuListIdandskuIdtogetOrganizationConfig:sku_list_idand:sku_idplaceholders to resolve correctly♻️ Refactor:
HostedCart— resolve order ID once viaresolvedOrderIdorder?.id ?? localStorage.getItem(persistKey)into a singleresolvedOrderIdvariable