Skip to content

Better login errors #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Airyzz merged 7 commits into from
Feb 28, 2026
Merged

Better login errors #677

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9d7d0ff
Alternative solution for better login errors
ollietheotter983 Feb 16, 2026
490ec21
Updating variables
ollietheotter983 Feb 17, 2026
de64d00
use showAdaptiveDialog
ollietheotter983 Feb 17, 2026
6faf636
Realiing the error of my ways
ollietheotter983 Feb 17, 2026
f6437e2
formatted
ollietheotter983 Feb 19, 2026
df8da13
Merge branch 'main' into pr/677
Airyzz Feb 28, 2026
89cd519
Update login_page.dart
Airyzz Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions commet/lib/ui/pages/login/login_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import 'package:commet/utils/debounce.dart';
import 'package:commet/utils/rng.dart';
import 'package:flutter/material.dart';
import 'package:intl/intl.dart';
import 'package:commet/ui/navigation/adaptive_dialog.dart';
import 'package:tiamat/tiamat.dart' as tiamat;

class LoginPage extends StatefulWidget {
const LoginPage({super.key, this.onSuccess, this.canNavigateBack = false});
Expand All @@ -20,14 +22,11 @@ class LoginPage extends StatefulWidget {
}

class LoginPageState extends State<LoginPage> {
String get messageLoginFailed => Intl.message("Login Failed...",
name: "messageLoginFailed",
desc: "Generic text to show that an attempted login has failed");

String get messageLoginError => Intl.message("An error occured",
name: "messageLoginError",
desc:
"A generic error message to convey that an error occured when attempting to login");
String get messageLoginFailed => Intl.message(
"Login Failed...",
name: "messageLoginFailed",
desc: "Generic text to show that an attempted login has failed",
);

String get messageAlreadyLoggedIn => Intl.message(
"You have already logged in to this account",
Expand All @@ -47,8 +46,9 @@ class LoginPageState extends State<LoginPage> {
List<LoginFlow>? loginFlows;
Client? loginClient;

final Debouncer homeserverUpdateDebouncer =
Debouncer(delay: const Duration(seconds: 1));
final Debouncer homeserverUpdateDebouncer = Debouncer(
delay: const Duration(seconds: 1),
);

bool loadingServerInfo = false;
bool isServerValid = false;
Expand All @@ -60,8 +60,9 @@ class LoginPageState extends State<LoginPage> {
MatrixClient.create(internalId).then((client) {
loginClient = client;

progressSubscription = loginClient!.connectionStatusChanged.stream
.listen(onLoginProgressChanged);
progressSubscription = loginClient!.connectionStatusChanged.stream.listen(
onLoginProgressChanged,
);
});

super.initState();
Expand Down Expand Up @@ -126,9 +127,11 @@ class LoginPageState extends State<LoginPage> {

if (message != null) {
if (mounted) {
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
content: Text(message),
AdaptiveDialog.show(
context,
title: "Login failed",
builder: (_) => tiamat.Text(
message,
),
);
}
Expand All @@ -146,7 +149,10 @@ class LoginPageState extends State<LoginPage> {
}

Future<void> doPasswordLogin(
PasswordLoginFlow flow, String username, String password) async {
PasswordLoginFlow flow,
String username,
String password,
) async {
if (loginClient == null) return;
flow.username = username;
flow.password = password;
Expand Down