[IMP]pms: includes board services in cancelation penalty#225
Closed
braisab wants to merge 2334 commits into16.0-mig-pmsfrom
Closed
[IMP]pms: includes board services in cancelation penalty#225braisab wants to merge 2334 commits into16.0-mig-pmsfrom
braisab wants to merge 2334 commits into16.0-mig-pmsfrom
Conversation
DarioLodeiros
force-pushed
the
16.0-mig-pms
branch
2 times, most recently
from
54b199d to
182b13c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to the
_check_cancel_penaltymethod inpms/models/pms_reservation.py, enhancing the calculation of cancellation penalties by including board services in specific scenarios.Enhancements to penalty calculation:
pms/models/pms_reservation.py: Updated_check_cancel_penaltyto account for board services when calculating penalties. Only services marked asis_board_serviceand consumed either "before" or "after" the reservation dates are included. Services consumed on the first or last day are excluded. The penalty amount now factors in the price and quantity of applicable service lines.