Skip to content

Stop OpenTelemetry log spam in tests #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vrslev merged 3 commits into from
Mar 10, 2026
Merged

Stop OpenTelemetry log spam in tests #136

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebce7ff
Add type hints and silence OpenTelemetry logs
vrslev Mar 10, 2026
96b734f
Remove redundant test file t.py
vrslev Mar 10, 2026
85d7c84
Remove redundant type ignore comment
vrslev Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions microbootstrap/instruments/opentelemetry_instrument.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations
import dataclasses
import logging
import os
import threading
import typing
Expand Down Expand Up @@ -35,7 +36,6 @@
from opentelemetry.metrics import Meter, MeterProvider
from opentelemetry.trace import TracerProvider


OpentelemetryConfigT = typing.TypeVar("OpentelemetryConfigT", bound="OpentelemetryConfig")


Expand Down Expand Up @@ -101,7 +101,7 @@ class BaseOpentelemetryInstrument(Instrument[OpentelemetryConfigT]):
ready_condition = "Provide all necessary config parameters"

def _load_instrumentors(self) -> None:
for entry_point in entry_points(group="opentelemetry_instrumentor"): # type: ignore[no-untyped-call]
for entry_point in entry_points(group="opentelemetry_instrumentor"):
if entry_point.name in self.instrument_config.opentelemetry_disabled_instrumentations:
continue

Expand Down Expand Up @@ -131,7 +131,9 @@ def teardown(self) -> None:
instrumentor_with_params.instrumentor.uninstrument(**instrumentor_with_params.additional_params)

def bootstrap(self) -> None:
attributes = {
logging.getLogger("opentelemetry.instrumentation.instrumentor").disabled = True
logging.getLogger("opentelemetry.trace").disabled = True
attributes: typing.Final = {
ResourceAttributes.SERVICE_NAME: self.instrument_config.opentelemetry_service_name
or self.instrument_config.service_name,
ResourceAttributes.TELEMETRY_SDK_LANGUAGE: "python",
Expand Down Expand Up @@ -169,7 +171,7 @@ def bootstrap(self) -> None:

class OpentelemetryInstrument(BaseOpentelemetryInstrument[OpentelemetryConfig]):
def define_exclude_urls(self) -> list[str]:
exclude_urls = [*self.instrument_config.opentelemetry_exclude_urls]
exclude_urls: typing.Final = [*self.instrument_config.opentelemetry_exclude_urls]
if (
not self.instrument_config.opentelemetry_generate_health_check_spans
and self.instrument_config.health_checks_path
Expand Down Expand Up @@ -197,16 +199,16 @@ def _is_root_span(span: ReadableSpan) -> bool:
class PyroscopeSpanProcessor(SpanProcessor):
def on_start(self, span: Span, parent_context: Context | None = None) -> None: # noqa: ARG002
if _is_root_span(span):
formatted_span_id = format_span_id(span.context.span_id)
thread_id = threading.get_ident()
formatted_span_id: typing.Final = format_span_id(span.context.span_id)
thread_id: typing.Final = threading.get_ident()

span.set_attribute(OTEL_PROFILE_ID_KEY, formatted_span_id)
pyroscope.add_thread_tag(thread_id, PYROSCOPE_SPAN_ID_KEY, formatted_span_id)
pyroscope.add_thread_tag(thread_id, PYROSCOPE_SPAN_NAME_KEY, span.name)

def on_end(self, span: ReadableSpan) -> None:
if _is_root_span(span):
thread_id = threading.get_ident()
thread_id: typing.Final = threading.get_ident()
pyroscope.remove_thread_tag(thread_id, PYROSCOPE_SPAN_ID_KEY, format_span_id(span.context.span_id))
pyroscope.remove_thread_tag(thread_id, PYROSCOPE_SPAN_NAME_KEY, span.name)

Expand Down