add WebSocketConnection class#177
Open
m2es3h wants to merge 7 commits intocommunity-of-python:mainfrom
Open
Conversation
…in websocket connection
Collaborator
|
Hi! This seems mostly fine. I can accept the PR if you adjust some stuff:
Too much hassle to create websocket-specific connection parameters. let's compromise and modify existing connection parameters |
Collaborator
|
Also this new class should be in separate file so that import doesn't fail if you don't have |
Author
|
I still need to follow-up with |
vrslev
reviewed
Feb 9, 2026
Collaborator
|
Test is flaky, but type checking fails |
Collaborator
|
Great, CI is passing! Let’s also mention stompman[ws] in the readme |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a use-case where I've been using the websocket adapter from stomp.py project (see stomp/adapter/ws.py in https://github.com/jasonrbriggs/stomp.py for reference).
I've recently switched to using stompman and added a WebSocketConnection class to support this use-case, based on your existing Connection class.
Known issue: no support for URL paths after the
ws://hostname:portyet. Do I modify the existing stompman.config.ConnectionParameters, or create a websocket-specific ConnectionParameters? Not sure which way is preferred.