docs(delphi): note subgroup-k-smoother clamp for D3 port (#2575)#2610
Merged
Conversation
When D3 (k-smoother buffer) is ported to Python, both the group AND subgroup smoothers must carry the stale-smoothed-k clamp (contains?-check), not the pre-#2536 unclamped logic. Clojure fixed the group level in #2536 and the subgroup level in #2575 (jc/subgroup-k-smoother-clamp). Added a warning to the D3 section of PLAN_DISCREPANCY_FIXES.md so this isn't re-discovered as a crash. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a porting note to the D3 (k-smoother buffer) section of
PLAN_DISCREPANCY_FIXES.md, following the Clojure fix in #2609 (issue #2575).When D3 is eventually ported to the Python/delphi pipeline, both k-smoother levels must carry the stale-
smoothed-kclamp — the group-levelgroup-k-smoother(Clojure fix #2536) and the per-group:subgroup-k-smoother(Clojure fix #2609 / #2575). Without the clamp at both levels, a group whose base-cluster count drops below a/12boundary can carry asmoothed-kthat no longer exists in the current clusterings, producing an empty clustering that crashesconv-repness. The note points at the reference implementation and tests so this isn't re-discovered as a crash during the port.Docs-only; no code changes.
Related
🤖 Generated with Claude Code