feat(delphi): replay loader resolves private datasets under real_data/.local#2651
Draft
jucor wants to merge 1 commit into
Draft
feat(delphi): replay loader resolves private datasets under real_data/.local#2651jucor wants to merge 1 commit into
jucor wants to merge 1 commit into
Conversation
This was referenced Jul 22, 2026
Draft
Draft
…/.local dataset_dir() only globbed real_data/*-<slug>, so the five private datasets (bg2018, pakistan, engage, bg2050, FLI — slugs allowed in code per the 2026-07-05 naming policy; report-id dirs still never appear) were invisible to the replay harness and could not join the certify battery. Now also searches real_data/.local/*-<slug>, with top-level (public) matches taking priority on slug collision. Groundwork for extending the battery to all real_data datasets (GOAL_R1_PARITY.md Battery section). commit-id:a543ecf1
Delphi Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dataset_dir() only globbed real_data/-, so the five private
datasets (bg2018, pakistan, engage, bg2050, FLI — slugs allowed in code
per the 2026-07-05 naming policy; report-id dirs still never appear) were
invisible to the replay harness and could not join the certify battery.
Now also searches real_data/.local/-, with top-level (public)
matches taking priority on slug collision. Groundwork for extending the
battery to all real_data datasets (GOAL_R1_PARITY.md Battery section).
commit-id:a543ecf1
Stack: