Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR extends the GitHub plugin to collect teams information in addition to organization settings. It restructures the data model to wrap both organization settings and teams data in a unified GithubData struct.
- Introduces a new
GithubDatastruct to hold both organization settings and teams information - Updates data fetching to retrieve teams data from the GitHub API
- Modifies policy evaluation to work with the new data structure
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| main.go | Added empty line for formatting |
| internal/data.go | Added GithubData struct and updated FetchData to retrieve teams information |
| internal/eval.go | Updated policy evaluator to work with new GithubData struct instead of raw organization |
| internal/eval_test.go | Updated test data and function calls to use new data structure |
| examples/policies/gh_org_mfa_enabled.rego | Updated policy to reference input.settings instead of input.organization |
| README.md | Updated documentation formatting and added teams permission requirement |
| Makefile | Added new Makefile with policy testing and validation targets |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.