Open
Conversation
Comment on lines
78
to
82
| if base == "" { | ||
| client.BaseURL = baseUrl | ||
| } else { | ||
| client.BaseURL = base | ||
| } |
There was a problem hiding this comment.
Not wrong, but the idiomatic way to do this in go would be:
Suggested change
| if base == "" { | |
| client.BaseURL = baseUrl | |
| } else { | |
| client.BaseURL = base | |
| } | |
| if base == "" { | |
| base = baseUrl | |
| } | |
| client.BaseURL = base |
saves us this else statement
Comment on lines
+78
to
+82
| if base == "" { | ||
| base = baseUrl | ||
| } | ||
| client.BaseURL = base | ||
| return client, nil |
There was a problem hiding this comment.
lol just realized this could be even simpler (because of the way the Client is initialized on lines 73-76)
Suggested change
| if base == "" { | |
| base = baseUrl | |
| } | |
| client.BaseURL = base | |
| return client, nil | |
| if base != "" { | |
| client.BaseUrl = base | |
| } | |
| return client, nil |
gusfcarvalho
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.