Merged
Conversation
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in step creation where native HTML number inputs can return numeric values instead of strings, causing a runtime error when .trim() is called on them.
Changes:
- Updated
parseGracePeriodInputto acceptstring | number | null | undefinedand normalize inputs internally - Fixed
StepDefinitionForm.vueto normalizegracePeriodDaysInput.valuebefore using it - Added test coverage for numeric inputs
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/views/workflows/partials/StepDefinitionForm.vue | Normalizes gracePeriodDaysInput value to string before validation to handle numeric values from number input |
| src/utils/workflows.ts | Updated parseGracePeriodInput to accept multiple types and normalize internally |
| src/utils/workflows.spec.ts | Added tests for numeric inputs to ensure they are handled correctly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.