archive: Fix another PAX header desync (GHSA-3cv2-h65g-fgmm)#454
Merged
Conversation
Per POSIX pax, a PAX `x` header applies to the next *file* entry, not any intermediary extension headers (GNU LongName `L`, etc.). Violating this lets an attacker craft a tar that extracts differently under tar-rs than under other parsers — a file smuggling vector. Mirrors astral-tokio-tar commit 36e734d (GHSA-3cv2-h65g-fgmm). Assisted-by: OpenCode (claude-sonnet-4-6@default) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
pax-desync-more
branch
from
b012942 to
077cecf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per POSIX pax, a PAX
xheader applies to the next file entry, not any intermediary extension headers (GNU LongNameL, etc.). Violating this lets an attacker craft a tar that extracts differently under tar-rs than under other parsers — a file smuggling vector.Mirrors astral-tokio-tar commit 36e734d (GHSA-3cv2-h65g-fgmm).
Assisted-by: OpenCode (claude-sonnet-4-6@default)