Narrow subject on matches#54
Merged
Merged
Conversation
staabm
commented
Jun 6, 2026
Comment on lines
+53
to
+54
| "@php vendor/bin/phpunit", | ||
| "@php vendor/bin/phpunit --testsuite phpstan" |
Contributor
Author
There was a problem hiding this comment.
composer test did not run phpstan tests before.
staabm
commented
Jun 6, 2026
Comment on lines
-96
to
-97
| // @phpstan-ignore function.alreadyNarrowedType | ||
| if (method_exists('PHPStan\Analyser\SpecifiedTypes', 'setRootExpr')) { |
Contributor
Author
There was a problem hiding this comment.
this was PHPStan 1.x compat code
Member
There was a problem hiding this comment.
Composer still runs phpstan 1 due to php7.2 support, but I guess this branch is 7.4+ so it's ok to drop it.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires phpstan/phpstan-src#5777