Skip to content

Update to latest SUNDIALS v7.6.0#169

Merged
davidcortesortuno merged 3 commits intomasterfrom
upgrade-sundials-v7.6.0
Feb 16, 2026
Merged

Update to latest SUNDIALS v7.6.0#169
davidcortesortuno merged 3 commits intomasterfrom
upgrade-sundials-v7.6.0

Conversation

@rpep
Copy link
Member

@rpep rpep commented Feb 7, 2026

Some changes to underlying library but nothing major, tests pass locally (fingers crossed for CI!)

@davidcortesortuno
Copy link
Collaborator

Is there any improvement in updating to Sundials 7.x ? From your commits the data types in the cvode pyx file look much cleaner :O

@rpep
Copy link
Member Author

rpep commented Feb 8, 2026

@davidcortesortuno not massively from what I can tell, just trying to stay relatively modern!

I've bumped fftw too, I had to remove the finalize though as it crashes with it when you reinit fftw. There's not really a good way to fix this properly, other than have a cleanup that only ones once in a singleton or something :/ The only real benefit to running finalize is that if you were for e.g. running a simulation that had Demag and then removed it, you'd have more memory available for the second stage, but I think it's probably unnecessary for this.

@davidcortesortuno
Copy link
Collaborator

Awesome. Regarding the fftw cleanup function, I guess we could wrap it and call it only if the user wanted to get rid of all created demag memory. Because if you create a new demag, my guess is that all fftw plans are created again?

@rpep
Copy link
Member Author

rpep commented Feb 16, 2026

@davidcortesortuno we already call fftw_destroy_plan, this is more like shared allocated global stuff across plans that gets cleaned up. It's absiclay only useful if you need full memory back after finishing all FFTs but if you are just ending the program obviously everything will be deallocated anyway.

@davidcortesortuno
Copy link
Collaborator

Indeed, yes. Also we never use more than one demag most of the time, so probably full deallocation is not that useful. I'll merge this PR if everything is passing.

@davidcortesortuno davidcortesortuno merged commit 9b0fb88 into master Feb 16, 2026
1 check passed
@rpep rpep deleted the upgrade-sundials-v7.6.0 branch February 17, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants