ENH: skip rest of file after failure#220
Draft
bsipocz wants to merge 3 commits intocomputationalmodelling:masterfrom
Draft
ENH: skip rest of file after failure#220bsipocz wants to merge 3 commits intocomputationalmodelling:masterfrom
bsipocz wants to merge 3 commits intocomputationalmodelling:masterfrom
Conversation
43ba043 to
6c7cc51
Compare
Contributor
Author
|
While now the new commits fixes the compatibility with rerunfailures, the returned traceback is incorrect (one cell lower in the stack, and thus makes no sense; e.g. undefined variable). So that adds a new TODO item for this PR, to track down if the error is due to this PR or due to rerunfailes. |
467f3e9 to
5d538a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address #145
Still draft as it doesn't work along withrerunfailures, and I don't yet see why.TODO checklist:
nbvalis not used and one runs pytest on a libraryAnd also it will need an option to opt-in (or I would prefer if this would be opt-out, but that means breaking current behaviour).