Extract rsync flags to environment variable#28
Open
conallob wants to merge 1 commit into
Open
Conversation
Replaces the inline flags in the gigabit-rsync alias with a RSYNC_FLAGS env variable so the flags are available on Linux/bash hosts and usable outside the alias too. https://claude.ai/code/session_01YGG2kzmhtuUopk8serBAPm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored rsync configuration to improve maintainability by extracting the gigabit transfer flags into an environment variable.
Changes
RSYNC_FLAGSenvironment variable toshell.d/envwith optimized flags for gigabit transfersgigabit-rsyncalias inshell.d/aliasto reference the new environment variable instead of hardcoding flagsImplementation Details
The rsync flags are now centralized in the environment configuration, making it easier to:
The flags remain unchanged and continue to follow the optimization recommendations from https://gist.github.com/KartikTalwar/4393116
https://claude.ai/code/session_01YGG2kzmhtuUopk8serBAPm