fix(mix): make animation transitions target-correct#965
Open
leoafarias wants to merge 2 commits into
Open
Conversation
Repair curve, spring, phase, and keyframe driver transitions as one lifecycle-contract change so they always render the requested target. - Curve delay holds the currently displayed spec (tween begin) instead of snapping back to the driver's immutable initialSpec on interruption. - Removing a phase/keyframe config disposes the old driver and exposes the new target on the same update; only curve/spring are reused for an animate-out, centralized in _outgoingConfigFor. - Phase delay placement uses the destination transition's config for both the delay check and its weight (incl. last -> first). - Phase completion fires exactly once via PhaseAnimationConfig.onEnd, registered once on the controller; the leaking curveConfigs.last.onEnd path is removed and onEnd is exposed on phaseAnimation(). - Phase/keyframe configs validate inputs at construction (empty phases, count mismatch, negative durations/delays, zero-duration loops, duplicate track ids). Adds 41 regression tests (full old->new driver matrix, interrupted delays, listener accumulation, delay boundaries, validation) that fail on origin/main and pass with the fix.
Restore `const` on PhaseAnimationConfig and KeyframeAnimationConfig by moving their invariant checks into a `validate()` method that the phase/keyframe drivers invoke in both their constructor and updateDriver. Invalid configs still fail before controller execution, while downstream const construction keeps compiling. KeyframeTrack keeps its own segment assert (it was never const). Adds driver-level tests proving each driver rejects an invalid config before running. Addresses code-review feedback on const compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #964 — Fix animation transition lifecycle and target correctness (P0).
Description
Repairs the curve, spring, phase, and keyframe animation drivers as one
lifecycle-contract change so interrupted transitions hold the visible value,
removing a phase/keyframe config reaches the new target immediately, phase
delays use the correct transition index, and phase completion fires exactly
once. Ships 43 regression tests that fail on
mainand pass with the fix.Changes
CurveAnimationDriverholds the displayed spec(
_tween.begin) during a delay instead of snapping back to_initialSpec._outgoingConfigFor()reuses anoutgoing config only for curve/spring; removing a phase/keyframe config
disposes the old driver and shows the new target on the same update.
for both the check and its weight (including last → first).
PhaseAnimationConfig.onEnd(registered once on the controller); the leaking
curveConfigs.last.onEndpath is removed and
onEndis exposed onphaseAnimation().validate()runs in the driver constructor andupdateDriver, before thecontroller runs — covering empty phases, count mismatch, negative
durations/delays, zero-duration loops, and duplicate track ids. Configs stay
const-constructible.interrupted delays, listener accumulation, delay boundaries, and validation
(config-level and driver-wiring).
Review Checklist
mainandpass with the fix;
dart analyzeanddcm analyze --fatal-style --fatal-warningsare clean.phaseAnimation(onEnd:); the previously-leakingcurveConfigs.last.onEndpath is no longer read. Called out here for release notes.
phaseAnimation/onEndupdated; no README changes needed.
btwld/mix-docssite should note the phaseonEndbehavior change — separate repo, tracked as a follow-up.Additional Information (optional)
The
onEndchange is a bug fix: a probe showed the old reachable path fired1 + rebuildstimes (3× after two updates) while the dedicated field was dead;the fix makes it fire exactly once through a discoverable param. Config
validation lives in a driver-invoked
validate()rather than the constructorsso the public
constconstruction path is preserved.