chore: update Mix to 2.1.0 and add mix_lint#61
Open
tilucasoli wants to merge 3 commits into
Open
Conversation
Bump mix, mix_annotations and mix_generator to ^2.1.0 (now published on pub.dev) and drop the feat/styler-generator git overrides. Regenerate the component *.g.dart outputs with the 2.1.0 generator. Add mix_lint with the Mix 2.0 rule set, configured via the analyzer `plugins:` field in a new workspace-root analysis_options.yaml. mix_lint 2.0.0 (the analysis_server_plugin rebuild) is sourced from git until it is published. Co-authored-by: Cursor <cursoragent@cursor.com>
Bump naked_ui from 0.2.0-beta.7 to 1.0.0-beta.1 and adapt RemixTooltip to the renamed NakedTooltip API: showDuration -> touchDelay, waitDuration -> hoverDelay, semanticsLabel -> semanticLabel. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the workspace to Mix ^2.1.0, regenerates Mix-generated component *.g.dart outputs accordingly, and adds workspace-root analyzer plugin configuration for mix_lint (sourced via a git override until published).
Changes:
- Bump
mix,mix_annotations,mix_generatorto^2.1.0, updatenaked_uito^1.0.0-beta.1, and simplify/remove previous Mix git overrides. - Add workspace-root
analysis_options.yamlenablingmix_lintdiagnostics via analyzerplugins:. - Regenerate component
*.g.dartfiles and adjustRemixTooltipto match updatednaked_uitooltip API.
Reviewed changes
Copilot reviewed 4 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Updates workspace deps and adds a git dependency_overrides entry for mix_lint. |
| pubspec.lock | Captures updated resolved dependency graph (Mix 2.1.0, new analyzer plugin deps, etc.). |
| packages/remix/pubspec.yaml | Bumps Mix deps to ^2.1.0, naked_ui to ^1.0.0-beta.1, adds mix_lint dev dependency. |
| analysis_options.yaml | Adds workspace-root analyzer plugin config enabling mix_lint diagnostics. |
| packages/remix/lib/src/components/tooltip/tooltip_widget.dart | Updates NakedTooltip usage to new parameter names and builder signature. |
| packages/remix/lib/src/components/tooltip/tooltip.g.dart | Regenerated Mix outputs (ordering changes + new modifier-related API). |
| packages/remix/lib/src/components/toggle/toggle.g.dart | Regenerated Mix outputs (ordering changes + new modifier-related API). |
| packages/remix/lib/src/components/textfield/textfield.g.dart | Regenerated Mix outputs (ordering changes + new modifier-related API). |
| packages/remix/lib/src/components/tabs/tabs.g.dart | Regenerated Mix outputs (debug property formatting + new modifier-related API). |
| packages/remix/lib/src/components/switch/switch.g.dart | Regenerated Mix outputs (new modifier-related API). |
| packages/remix/lib/src/components/spinner/spinner.g.dart | Regenerated Mix outputs (ordering changes + new modifier-related API). |
| packages/remix/lib/src/components/slider/slider.g.dart | Regenerated Mix outputs (ordering changes + new modifier-related API). |
| packages/remix/lib/src/components/select/select.g.dart | Regenerated Mix outputs (ordering changes + new modifier-related API). |
| packages/remix/lib/src/components/radio/radio.g.dart | Regenerated Mix outputs (new modifier-related API). |
| packages/remix/lib/src/components/progress/progress.g.dart | Regenerated Mix outputs (ordering changes + new modifier-related API). |
| packages/remix/lib/src/components/menu/menu.g.dart | Regenerated Mix outputs (ordering changes + new modifier-related API). |
| packages/remix/lib/src/components/icon_button/icon_button.g.dart | Regenerated Mix outputs (new modifier-related API). |
| packages/remix/lib/src/components/divider/divider.g.dart | Regenerated Mix outputs (debug property formatting + new modifier-related API). |
| packages/remix/lib/src/components/dialog/dialog.g.dart | Regenerated Mix outputs (ordering changes + new modifier-related API). |
| packages/remix/lib/src/components/checkbox/checkbox.g.dart | Regenerated Mix outputs (new modifier-related API). |
| packages/remix/lib/src/components/card/card.g.dart | Regenerated Mix outputs (debug property formatting + new modifier-related API). |
| packages/remix/lib/src/components/callout/callout.g.dart | Regenerated Mix outputs (ordering changes + new modifier-related API). |
| packages/remix/lib/src/components/badge/badge.g.dart | Regenerated Mix outputs (new modifier-related API). |
| packages/remix/lib/src/components/avatar/avatar.g.dart | Regenerated Mix outputs (ordering changes + new modifier-related API). |
| packages/remix/lib/src/components/accordion/accordion.g.dart | Regenerated Mix outputs (ordering changes + new modifier-related API). |
Files not reviewed (20)
- packages/remix/lib/src/components/accordion/accordion.g.dart: Generated file
- packages/remix/lib/src/components/avatar/avatar.g.dart: Generated file
- packages/remix/lib/src/components/badge/badge.g.dart: Generated file
- packages/remix/lib/src/components/callout/callout.g.dart: Generated file
- packages/remix/lib/src/components/card/card.g.dart: Generated file
- packages/remix/lib/src/components/checkbox/checkbox.g.dart: Generated file
- packages/remix/lib/src/components/dialog/dialog.g.dart: Generated file
- packages/remix/lib/src/components/divider/divider.g.dart: Generated file
- packages/remix/lib/src/components/icon_button/icon_button.g.dart: Generated file
- packages/remix/lib/src/components/menu/menu.g.dart: Generated file
- packages/remix/lib/src/components/progress/progress.g.dart: Generated file
- packages/remix/lib/src/components/radio/radio.g.dart: Generated file
- packages/remix/lib/src/components/select/select.g.dart: Generated file
- packages/remix/lib/src/components/slider/slider.g.dart: Generated file
- packages/remix/lib/src/components/spinner/spinner.g.dart: Generated file
- packages/remix/lib/src/components/switch/switch.g.dart: Generated file
- packages/remix/lib/src/components/tabs/tabs.g.dart: Generated file
- packages/remix/lib/src/components/textfield/textfield.g.dart: Generated file
- packages/remix/lib/src/components/toggle/toggle.g.dart: Generated file
- packages/remix/lib/src/components/tooltip/tooltip.g.dart: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
35
to
37
| return NakedTooltip( | ||
| overlayBuilder: (context, info) => | ||
| overlayBuilder: (context, animation) => | ||
| Box(styleSpec: spec.container, child: tooltipChild), |
Comment on lines
+14
to
+18
| mix_lint: | ||
| git: | ||
| url: https://github.com/btwld/mix.git | ||
| ref: feat/styler-generator | ||
| path: packages/mix | ||
| mix_annotations: | ||
| git: | ||
| url: https://github.com/btwld/mix.git | ||
| ref: feat/styler-generator | ||
| path: packages/mix_annotations | ||
| mix_generator: | ||
| git: | ||
| url: https://github.com/btwld/mix.git | ||
| ref: feat/styler-generator | ||
| path: packages/mix_generator | ||
| ref: main | ||
| path: packages/mix_lint |
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mix,mix_annotationsandmix_generatorto^2.1.0. The styler-generator work this repo previously pulled from thefeat/styler-generatorgit branch has shipped in the published2.1.0line, so thedependency_overridesfor those packages are removed and Mix now resolves from pub.dev.*.g.dartwith the 2.1.0 generator (field reordering + the newmodifier(WidgetModifierConfig)setter from@MixableModifier).mix_lintwith the Mix 2.0 rule set, enabled via the analyzerplugins:field in a new workspace-rootanalysis_options.yaml(the analyzer rejectsplugins:inside member packages).mix_lint 2.0.0(theanalysis_server_pluginrebuild required for this config) is not yet published, so it is sourced from git via adependency_override.Follows the mix_lint tutorial.
Test plan
flutter pub getresolves (mix/mix_annotations/mix_generator at 2.1.0, mix_lint 2.0.0 from git)dart run build_runner buildregenerates outputs cleanlyflutter analyzeon the remix package → No issues foundMade with Cursor