Skip to content

Adding McRae-2005-541#1520

Merged
MiraAhmedovic merged 2 commits into
masterfrom
McRae-2005-541
Apr 23, 2026
Merged

Adding McRae-2005-541#1520
MiraAhmedovic merged 2 commits into
masterfrom
McRae-2005-541

Conversation

@MiraAhmedovic
Copy link
Copy Markdown
Collaborator

Pull request checklist

  • add new concept list
  • add new metadata
  • add new Concepticon concept sets
    • checked whether the new concept(s) can be applied to existing lists with
      concepticon notlinked --gloss "NEW_GLOSS"
  • add new Concepticon concept relations
  • refine existing Concepticon concept set mappings
  • refine Concepticon glosses
  • refine Concepticon concept relations
  • refine Concepticon concept definitions
  • retire data

Additional information

@MiraAhmedovic
Copy link
Copy Markdown
Collaborator Author

@AnnikaTjuka, could you moderate?

@AnnikaTjuka
Copy link
Copy Markdown
Collaborator

Sure. @alzkuc and @FredericBlum Would you have time to review the PR? @MiraAhmedovic Could you please send them the Google sheet?

Copy link
Copy Markdown
Collaborator

@FredericBlum FredericBlum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure :)

I left some changes about the concepts, and I didn't quite get the relation between Kucera1967, McRae 2005, and the source/list. It's probably quite straightforward if you are deeper into the topic, so perhaps you could briefly elaborate and elif? @MiraAhmedovic

Comment thread concepticondata/conceptlists/McRae-2005-541.tsv Outdated
Comment thread concepticondata/conceptlists/McRae-2005-541.tsv
McRae-2005-541-298 298 missile 2.60 2 5 2 3 0 1 0 0 0 4
McRae-2005-541-299 299 mittens 867 GLOVE 6.45 1 4 0 3 1 0 0 0 0 6
McRae-2005-541-300 300 mixer 5.90 1 3 0 3 0 1 0 0 0 1
McRae-2005-541-301 301 mole_(animal) 2.55 2 0 2 6 1 0 0 0 1 2
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread concepticondata/conceptlists/McRae-2005-541.tsv
McRae-2005-541-538 538 yacht 3.85 1 5 0 3 0 0 0 0 0 5
McRae-2005-541-539 539 yam 410 YAM 3.30 1 2 0 0 1 0 1 0 0 2
McRae-2005-541-540 540 zebra 3675 ZEBRA 2.60 3 2 2 5 2 0 0 0 0 2
McRae-2005-541-541 541 zucchini 5.10 1 4 0 4 3 0 1 0 0 2
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread concepticondata/references/references.bib Outdated
Comment thread concepticondata/references/references.bib Outdated
Comment thread concepticondata/conceptlists.tsv
Copy link
Copy Markdown
Collaborator

@alzkuc alzkuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MiraAhmedovic, just a few tiny suggestions, but looks good to me. Many of the unmapped concepts appear in other datasets.

Comment thread concepticondata/conceptlists/McRae-2005-541.tsv Outdated
Comment thread concepticondata/conceptlists/McRae-2005-541.tsv
Comment thread concepticondata/conceptlists/McRae-2005-541.tsv
Comment thread concepticondata/conceptlists/McRae-2005-541.tsv
@MiraAhmedovic
Copy link
Copy Markdown
Collaborator Author

Thank you for the reviews @FredericBlum & @alzkuc! I've changed the files now.

Copy link
Copy Markdown
Collaborator

@AnnikaTjuka AnnikaTjuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. @FredericBlum Could you approve your requested changes so that @MiraAhmedovic can merge?

@FredericBlum
Copy link
Copy Markdown
Collaborator

Done :)

@MiraAhmedovic MiraAhmedovic merged commit 43f0d01 into master Apr 23, 2026
1 check passed
@MiraAhmedovic MiraAhmedovic deleted the McRae-2005-541 branch April 29, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List of 541 English concepts with familiarity ratings (McRae et al. 2005)

4 participants