fix of concepts#1524
Merged
Merged
Conversation
Collaborator
Author
|
Took advantage of this PR to map some other missing concepts, esp. those listed in #1519 |
AnnikaTjuka
reviewed
Apr 30, 2026
Collaborator
AnnikaTjuka
left a comment
AnnikaTjuka
left a comment
There was a problem hiding this comment.
Thanks for the update, @FredericBlum! I saw a few concepts that I wasn't aware of! For example, I didn't know that we had distinct concept sets for macaws based on their colour!
AnnikaTjuka
approved these changes
May 1, 2026
Collaborator
AnnikaTjuka
left a comment
AnnikaTjuka
left a comment
There was a problem hiding this comment.
Thanks, looks good!
Collaborator
Author
|
Thanks for the review! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
concepticon notlinked --gloss "NEW_GLOSS"Additional information
Fixing three mappings in concept lists of South American languages. Note that we currently have a small assymmetry in SON (OF MALE EGO) and SON OF WOMAN - if you want we can also adapt this and rename to SON (OF FEMALE EGO), in agreement with other kinship terms in the database. If you want, I could add this to the PR.
@LinguList @AnnikaTjuka Could one of you review and approve this?