Fixed comparison checks for function names and general cleanup#2
Open
emilhdiaz wants to merge 1 commit intoconcon121:masterfrom
Open
Fixed comparison checks for function names and general cleanup#2emilhdiaz wants to merge 1 commit intoconcon121:masterfrom
emilhdiaz wants to merge 1 commit intoconcon121:masterfrom
Conversation
|
@concon121 we've just experienced same problem where two functions with very similar name got this same log group. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@concon121
I started trying to fix an issue I noticed in
getLogGroupName, where if two functions shared a similar game (e.g.get-teamandget-team-members), the LogGroup resource would get duplicated in the generated CF template. I fixed that, pruned some unused lines of code and re-organized a bit.Would you be open to taking a look at this?