Conversation
…animation rate and increase retry timeout for animation-dependent assertions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #2441 +/- ##
===========================================
- Coverage 85.32% 69.78% -15.55%
===========================================
Files 763 763
Lines 42310 42310
Branches 10071 10071
===========================================
- Hits 36102 29525 -6577
- Misses 6196 12779 +6583
+ Partials 12 6 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 02m 11s |
| Commit |
|
| Committer | github-actions[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
4
|
| View all changes introduced in this branch ↗︎ | |
There was a problem hiding this comment.
Pull request overview
This PR addresses flakiness in the Slider Cypress E2E test by ensuring the slider’s inspector palette doesn’t obstruct the play/pause controls and by extending the retry window for assertions that depend on animation timing.
Changes:
- Close the slider inspector palette after setting the animation rate to avoid UI overlap with the play/pause button.
- Add an optional timeout parameter to the slider variable value input lookup helper.
- Update animation-dependent assertions in
slider.spec.tsto wait up to 15s for the slider value to reach expected targets.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| v3/cypress/support/elements/slider-tile.ts | Adds optional timeout to getVariableValueInput() and closes the inspector palette after setting animation rate. |
| v3/cypress/e2e/slider.spec.ts | Uses getVariableValueInput(..., 15000) with contain.value assertions for animation-dependent waits. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Merging without human review, as it's just a test change. |
Summary
setAnimationRate(), preventing the palette from covering the play/pause button (the CI failure on smaller viewports)Test plan
npx cypress run --spec cypress/e2e/slider.spec.tspasses locally🤖 Generated with Claude Code