185847976 numberline point values

[dennisrcao]

Fulfills the following ticket:
[NLine] Numberline Point Values

---

LocalHost
http://localhost:8080/?appMode=demo&demoName=dennis&fakeClass=1&fakeUser=teacher:1&unit=example-config-subtabs&problem=1.1

Deployed Link

https://collaborative-learning.concord.org/branch/numberline-point-values/?appMode=demo&demoName=dennis3&fakeClass=1&fakeUser=teacher:1&unit=example

[cypress]

Passing run #11737 ↗︎

0

90

5

0

0

Details:

null
Project: collaborative-learning	Commit: a65a914cc5
Status: Passed	Duration: 11:18 💡
Started: Mar 19, 2024 10:56 PM	Ended: Mar 19, 2024 11:07 PM

Review all test suite changes for PR #2229 ↗︎

[codecov]

Codecov Report

Attention: Patch coverage is 7.14286% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 55.06%. Comparing base (39c3393) to head (32fbf0b).

❗ Current head 32fbf0b differs from pull request most recent head a65a914. Consider uploading reports for the commit a65a914 to get more accurate results

Files	Patch %	Lines
.../plugins/numberline/components/numberline-tile.tsx	0.00%	49 Missing ⚠️
...line/components/editable-numberline-min-or-max.tsx	25.00%	3 Missing ⚠️

Additional details and impacted files

@@                          Coverage Diff                          @@
##           187056474-numberline-open-points    #2229       +/-   ##
=====================================================================
- Coverage                             82.27%   55.06%   -27.21%     
=====================================================================
  Files                                   688      681        -7     
  Lines                                 34103    34056       -47     
  Branches                               8841     8832        -9     
=====================================================================
- Hits                                  28058    18754     -9304     
- Misses                                 5714    14569     +8855     
- Partials                                331      733      +402     

Flag	Coverage Δ
cypress-regression	?
cypress-smoke	30.08% <7.14%> (-0.03%)	⬇️
jest	51.94% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dennisrcao]

In case QA @johnTcrawford finds an issue where we create a point and then set the min greater than it, and the point persists off the numberline (when it should disappear) - then please ignore that edge case - we'll address that in a later ticket
https://www.pivotaltracker.com/n/projects/2441242/stories/187232408

[scytacki]

looks good to me

[scytacki]

There are cases where the point can't be moved so the value in label matches the tick mark that the point is on. For example the value might only show 5.99 or 6.01 and you can't move it to show 6.00. I've brought this up with Leslie. It isn't an easy problem to fix, so I wouldn't try unless it is required.

[scytacki]

Leslie found an issue where the sparrows do not align with the points anymore. I'll work on fixing that later.

[johnTcrawford]

There is no Cypress code here (so far, at least), so I'm not sure why I was asked to review it. Is it because there is a plan to add Cypress code later, or was it just a mistake?