Open
Conversation
collaborative-learning
|
||||||||||||||||||||||||||||
| Project |
collaborative-learning
|
| Branch Review |
CLUE-187-read-only-highlight-sparrow
|
| Run status |
|
| Run duration | 23m 17s |
| Commit |
|
| Committer | eireland |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
4
|
Skipped
|
0
|
Passing
|
149
|
| View all changes introduced in this branch ↗︎ | |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2621 +/- ##
==========================================
+ Coverage 86.18% 86.20% +0.01%
==========================================
Files 782 782
Lines 42276 42272 -4
Branches 10787 10785 -2
==========================================
+ Hits 36435 36439 +4
+ Misses 5526 5518 -8
Partials 315 315
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bgoldowsky
suggested changes
Aug 4, 2025
Contributor
bgoldowsky
left a comment
bgoldowsky
left a comment
There was a problem hiding this comment.
I do not recommend that we merge this PR without more work.
It fixes some cases but breaks others that used to work; for instance, sparrows no longer get repositioned properly as you are editing text in the text tile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made tracking highlight boxes in text tile state instead of text content model. Sparrows are now appearing in both edit and read-only views. Sparrows are drawing correctly in edit view, but not in read only view. The read only view draws the sparrows as they look in the edit view, not where the highlight chips are in the read-only view.