Open
Conversation
- group documents just use the firestore metadata instead of having firebase metadata too. This is a pattern that all documents should change to eventually. - group document content is stored in a different place firebase because they don't have a user. We could use the fake uid that is created for them so they could be stored in the same place in firebase that the other documents are stored, but this seems like it would lead to more problems.
This also enables reloading the page when a group document is open.
replace "group" with GroupDocument
Also: - save the firebase metadata for the document so it is consistent with other CLUE documents. This removes some complexity around the createdAt timestamp. - remove some console logs. - revert the useSyncMst*ToFirebase to requiring a path as a string which makes more sense. However keep them checking for a non-empty path to prevent weird behavior - have createDocument return the firestore metadata that it creates, so it can be used by other code - add an official VisibilityType to unify "public" | "private" typing. - add a type guard for DocumentType, this makes it safer when loading in documents from Firestore and other places.
…initial Initial Group Doc support
- unify document title component used in sort-work-document-area and document-view - note that use-document-caption has overlapping features with the document-title - update db.ts so the document.self is not required to get the documentKey, some documents do not have this set and it isn't really needed - add GroupDocument as a sortable type - update getDocumentDisplayTitle to handle group documents. - move some createDocMapBy* into the DocumentGroup to simplify the code - update the byGroup and byName groupings so they handle group documents
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…sort-work CLUE-314 show group docs in sort work
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2720 +/- ##
==========================================
- Coverage 86.20% 85.67% -0.53%
==========================================
Files 849 851 +2
Lines 46449 46725 +276
Branches 12072 12133 +61
==========================================
- Hits 40040 40033 -7
- Misses 6002 6679 +677
+ Partials 407 13 -394
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
collaborative-learning
|
||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
collaborative-learning
|
| Branch Review |
group-documents
|
| Run status |
|
| Run duration | 09m 47s |
| Commit |
|
| Committer | Scott Cytacki |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
3
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
175
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/functional/tile_tests/tile_navigator_spec.js • 1 failed test • Regression tests
| Test | Artifacts | |
|---|---|---|
| Tile Navigator > can be hidden and shown |
Test Replay
Screenshots
|
|
xy_plot_tool_spec.js • 1 flaky test • Regression tests
| Test | Artifacts | |
|---|---|---|
| XYPlot Tool Tile > XYPlot Tool > Test duplicating graph with an xy-plot (a.k.a. graph) |
Test Replay
Screenshots
|
|
table_tool_spec.js • 1 flaky test • Regression tests
| Test | Artifacts | |
|---|---|---|
| Table Tool Tile > should handle table row reordering |
Test Replay
Screenshots
|
|
diagram_tool_spec.js • 1 flaky test • Regression tests
| Test | Artifacts | |
|---|---|---|
| Diagram Tool Tile > Shared Variable Tiles (Diagram, Drawing) |
Test Replay
Screenshots
|
|
Use a Firestore transaction and the metadata to safely track the last history entry when multiple users are adding history entries at the same time.
This also add a log statement to make it a little easier to track down where in the test it is failing.
this was done to get access to a newer advanced timer function that handled async code better.
- check what getConfirmLogUrl is called with. - remove unused functions from jest-jsdom-environment - suppress the error message from jsdom when location.assign is used.
…ager-refactor CLUE-341 Refactor FirestoreHistoryManager and TreeManager
most complex change is better error handling in uploadQueuedHistoryEntries. The approach doesn't fully fix the problem, but at least it prevents a messed up uploadInProgress state.
…roup-docs-merge
resolved conflicts in: - sort-document-utils.ts - document-group.ts - app-config-model.test.ts - history-view-panel.tsx - Canvas.js - single_student_canvas_test.js
Resolved conflicts in: - document-file-menu.tsx (combined useMemo from master with group doc option) - document-file-menu.test.tsx (combined both test suites - basic menu ops and group doc visibility) - document-utils.ts (kept GroupDocument import, removed duplicate imports) - document-group.ts (kept inline byGroup with GroupDocument handling, added upperWords) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…merge CLUE-341-group-docs-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work is ready now, it has many changes which have been reviewed in individual PRs.