Merged
Conversation
JasonDictos
force-pushed
the
jdictos/docker-secrets
branch
from
544f7c7 to
e818bea
Compare
Closed
Contributor
|
Hi @JasonDictos , thank you for the PR. Is there any reason to include the go.mod bumps in this PR? If not, please extract them to keep this PR lean. |
Contributor
Author
@xtremerui Done |
Signed-off-by: Jason Dictos <jdictos@een.com>
JasonDictos
force-pushed
the
jdictos/docker-secrets
branch
from
e818bea to
d6b861c
Compare
xtremerui
approved these changes
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ssh identity support to the concourse yaml
Original work: #331
Tests pass locally however I cannot determine why the concourse-ci/status failed