feat: add Task.runtimeMetadata for host-resolved worker secrets#124
Open
NicholasDCole wants to merge 1 commit into
Open
feat: add Task.runtimeMetadata for host-resolved worker secrets#124NicholasDCole wants to merge 1 commit into
NicholasDCole wants to merge 1 commit into
Conversation
The server can resolve a worker's declared TaskDef.runtimeMetadata secret names at poll time and deliver the values on the wire-only Task.runtimeMetadata (conductor-oss PR #1255) — never persisted to task input. Add the field to the client Task model so it is not dropped on deserialization. - Map<String,String> runtimeMetadata with @JsonInclude(NON_EMPTY) (empty omitted). - Lombok @DaTa supplies the getter/setter; @builder support included. - TaskRuntimeMetadataSerDeTest: round-trips the field, omits it when empty. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
Map<String,String> runtimeMetadatafield to the clientTaskmodel.The server can resolve a worker's declared
TaskDef.runtimeMetadatasecret names at poll time and deliver the resolved values on the wire-onlyTask.runtimeMetadata(never persisted to task input). Without this field on the client model, that data is silently dropped on deserialization.Changes
Task.runtimeMetadata(Map<String,String>),@JsonInclude(NON_EMPTY)so it's omitted when empty. Lombok@Datasupplies the getter/setter.TaskRuntimeMetadataSerDeTest— round-trips the field, omits it when empty.Test
./gradlew :conductor-client:test --tests "*TaskRuntimeMetadataSerDeTest"passes; validated fail-first (flipping@JsonIncludetoALWAYSfails the omit-when-empty assertion).🤖 Generated with Claude Code