Skip to content

Conversation

@xli1996
Copy link
Member

@xli1996 xli1996 commented Jan 29, 2026

Release Notes

New Features

Add "s3vectrors" connection type support for confluent flink connection

Checklist

  • I have successfully built and used a custom CLI binary, without linter issues from this PR.
  • I have clearly specified in the What section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
  • I have verified this PR in Confluent Platform on-premises environment, if applicable.
  • I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • I have added appropriate CLI integration or unit tests for any new or updated commands and functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Confluent Platform
    • Check this box if the feature is enabled for certain organizations only

What

Add new flink s3vectors connection, this pr applies to CC.

Blast Radius

this should only affect new s3vectors type connection

References

Test & Review

Screenshot 2026-01-29 at 12 13 04 PM creds are just mocked one

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@sonarqube-confluent
Copy link

@xli1996 xli1996 marked this pull request as ready for review January 29, 2026 20:14
@xli1996 xli1996 requested a review from a team as a code owner January 29, 2026 20:14
Copilot AI review requested due to automatic review settings January 29, 2026 20:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for two new Flink connection types: "cosmosdb" and "s3vectors" to the Confluent CLI. The changes enable users to create and manage connections to Azure Cosmos DB using API keys and AWS S3 Vectors using AWS credentials.

Changes:

  • Added "cosmosdb" and "s3vectors" to the list of supported connection types
  • Updated authentication parameter mappings for both new connection types
  • Added test cases and golden fixtures for the new connection types

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/flink_test.go Added test cases for creating cosmosdb and s3vectors connections
test/fixtures/output/flink/connection/create/create-s3vectors.golden Golden file showing expected output for s3vectors connection creation
test/fixtures/output/flink/connection/create/create-cosmosdb.golden Golden file showing expected output for cosmosdb connection creation
test/fixtures/output/flink/connection/*.golden Updated help text and error messages to include new connection types
pkg/flink/utils.go Added cosmosdb and s3vectors to connection type mappings and authentication configurations
cmd/lint/main.go Added new connection type names to vocabulary whitelist

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants