Skip to content
This repository was archived by the owner on Mar 24, 2022. It is now read-only.

Docker-compose support with ordered and delayed startup#22

Open
Brian Towles (wonderslug) wants to merge 2 commits intoconfluentinc:masterfrom
wonderslug:feature/compose-setup
Open

Docker-compose support with ordered and delayed startup#22
Brian Towles (wonderslug) wants to merge 2 commits intoconfluentinc:masterfrom
wonderslug:feature/compose-setup

Conversation

@wonderslug
  • Added dockerize to platform to allow containers to wait for services to be available
  • Added docker-compose file for single command ordered start-up.

Brian Towles added 2 commits February 8, 2016 12:36
for services to be available
- Added docker-compose file for single command ordered start-up.
@ghost
Copy link

It looks like Brian Towles (@wonderslug) hasn't signed our Contributor License Agreement, yet.

Appreciation of efforts,

clabot

@mmaybeno

Not sure why the CLA was not posted in the bot's response, but this PR would be of interest to me instead of manually restarting the schema registry. Brian Towles (@wonderslug) you can find the CLA here: http://clabot.confluent.io/cla

@jcustenborder
Copy link
Contributor

Hey Matt! Thanks for the pull request. Have you looked at
examples/fullstack? This has a docker-compose script of the whole platform.

On Mon, Jun 13, 2016, 5:15 PM Matt Maybeno notifications@github.com wrote:

Not sure why the CLA was not posted in the bot's response, but this PR
would be of interest to me instead of manually restarting the schema
registry. Brian Towles (@wonderslug) https://github.com/wonderslug you can find the
CLA here: http://clabot.confluent.io/cla


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#22 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAMzgLmuL-8oV4cty3ZLueC5yzhF37RQks5qLchtgaJpZM4HVyFW
.

@mmaybeno

Hi Jeremy Custenborder (@jcustenborder). I'm actually not the maintainer of the PR but I have found it's solution useful. The problem with the docker-compose.yml file in examples/fullstack is that they are all started in the correct order, but there is no delay in making sure each service is up before proceeding. What that does is fail kafka, schema registry, and the rest proxy. The current solution is to just restart those in order.

The PR pulls in dockerize which will delay each service till they are fully up. I had planned to do something similar polling the zookeeper port till it was open but this is a much better solution.

@jcustenborder
Copy link
Contributor

Thanks Matt Maybeno (@mmaybeno)! I was on my phone when I responded so It looked like the request was from you. We'll take a look at dockerize.

@mmaybeno

I've been hacking on it a bit as well so if I have a good solution I'll make another PR. I noticed this one is based off an old master commit.

@mmaybeno

ended up making my own version using dockerize:
#43

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants