This repository was archived by the owner on Mar 24, 2022. It is now read-only.
Docker beta changes#44
Open
Christopher Matta (cjmatta) wants to merge 2 commits intoconfluentinc:masterfrom
Open
Docker beta changes#44Christopher Matta (cjmatta) wants to merge 2 commits intoconfluentinc:masterfrom
Christopher Matta (cjmatta) wants to merge 2 commits intoconfluentinc:masterfrom
Conversation
|
It looks like Christopher Matta (@cjmatta) hasn't signed our Contributor License Agreement, yet. Appreciation of efforts, clabot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm running the Docker beta for Mac and these changes were required for the
build.shto work.I'm not really sure what the best way to go about making this backwards compatible, maybe a
DOCKER_VERSIONentry insettings.shand a check for that along with the check forDOCKER_HOST?