Cleanup Streams init#815
Open
Simon Podlipsky (simPod) wants to merge 1 commit intoconfluentinc:6.0.0-postfrom
Open
Cleanup Streams init#815Simon Podlipsky (simPod) wants to merge 1 commit intoconfluentinc:6.0.0-postfrom
Simon Podlipsky (simPod) wants to merge 1 commit intoconfluentinc:6.0.0-postfrom
Conversation
Remove handling of "Streams never finished rebalancing on startup" as it's no longer required
Yeva Byzek (ybyzek)
suggested changes
Sep 30, 2020
Contributor
Yeva Byzek (ybyzek)
left a comment
Yeva Byzek (ybyzek)
left a comment
There was a problem hiding this comment.
Simon Podlipsky (@simPod) these changes cannot be made independently from the original source code at https://github.com/confluentinc/kafka-streams-examples/tree/6.0.0-post/src/main/java/io/confluent/examples/streams/microservices . The files here are from that kafka-streams-examples repo, with certain lines removed. So this PR could only be approved if the corresponding changes are first merged in kafka-streams-examples
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove handling of "Streams never finished rebalancing on startup" as it's no longer required (I believe it is some relict to prevent a bug that existed in Kafka v0.x)