fix(strictKex): null check in isStrictKex#504
Merged
Conversation
If one calls the isStrictKex before negotiation has completed, the negotiated parameters would be null and result in a NullPointerException. Change the semantics of the call slightly to mean "has strict KEX been negotiated."
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts KexManager.isStrictKex() semantics to mean “has strict KEX been negotiated (yet)?” and adds a regression test to prevent a NullPointerException when the method is called before KEX negotiation completes.
Changes:
- Add a null-safe check in
KexManager.isStrictKex()to avoid NPEs before negotiated parameters are available. - Add a JUnit test covering
isStrictKex()behavior prior to negotiation completion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/main/java/com/trilead/ssh2/transport/KexManager.java |
Makes isStrictKex() safe to call when KEX negotiation has not completed. |
src/test/java/com/trilead/ssh2/transport/KexManagerTest.java |
Adds regression coverage for calling isStrictKex() before negotiation completion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kruton
force-pushed
the
strict-kex-null-check
branch
from
ec51aae to
ffd456e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one calls the isStrictKex before negotiation has completed, the negotiated parameters would be null and result in a NullPointerException. Change the semantics of the call slightly to mean "has strict KEX been negotiated."