Added fn from_ansi_str for StyledObject#167
Open
BppleMan wants to merge 5 commits intoconsole-rs:mainfrom
Open
Added fn from_ansi_str for StyledObject#167BppleMan wants to merge 5 commits intoconsole-rs:mainfrom
BppleMan wants to merge 5 commits intoconsole-rs:mainfrom
Conversation
this is method can parse a string with ansi escape code and return a vector of StyledObject
Collaborator
|
This looks good but I think it would be better to change this to return an Iterator instead. Also please add an example docstring showing this is to be used, maybe just use the example from #166. |
Author
|
Refactor parser into iterator, and provide it together with AnsiCodeIterator following ansi_parse feature, optimize unit test |
Author
|
Any suggestions on where to add more documentation? |
Author
|
@mitsuhiko can you review this pr |
mitsuhiko
requested changes
Jan 9, 2024
| libc = "0.2.30" | ||
| unicode-width = { version = "0.1", optional = true } | ||
| lazy_static = "1.4.0" | ||
| regex = "1.4.2" |
Collaborator
There was a problem hiding this comment.
This should be an optional dependency. Code that depends on it then should also be feature gated.
| } | ||
|
|
||
| impl Style { | ||
| pub fn get_fg(&self) -> Option<Color> { |
Collaborator
There was a problem hiding this comment.
Why are these APIs added? Let's not add these unless there is a reason (maybe follow up PR), and if they are added, they need docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is method can parse a string with ansi escape code and return a vector of StyledObject