Conversation
|
Please change the title to your pull request to briefly reflect what it does. |
tiberiugila
changed the title
|
I'd highly appreciate seeing this merged, as it'd help my work on creating a |
| self.fg(Color::Aqua) | ||
| } | ||
| #[inline] | ||
| pub fn brightwhite(self) -> Style { |
There was a problem hiding this comment.
This (and on_brightwhite()) should use bright_white to match the naming conventions.
djc
changed the title
@JeromeSchmied I started to help maintaining this crate in December and have been doing passive maintenance (mostly because I am an indicatif maintainer and this is a dependency of that crate). Since this hadn't been touched for a while, I didn't spend time on it. It looks fairly straightforward to me so I think we can merge this once the naming issue has been fixed. I don't know if @tiberiugila is still interested in following up, if they don't respond in a week or so feel free to take this PR and resubmit it. |
|
fair enough, thanks for checking! |
|
I don't want to dunk on anyone's work, we're all doing this for free here, but how about we actually name colors meaningfully like it's done by owo_colors. Having bright variants of base colors like red, green, yellow and blue would be much more useful than trying to guess what is Navy, Fuchsia, Maroon or others. |
|
I'm open for submitting the PR myself, it just really bugs me that my indicatif progress bars are stuck with whatever we currently have while owo_colors is living it large. And they also have |
6 participants
Fixed #177 also added the first 16 colors to the color enum