Support of reading the is_tty status of stdin#200
Open
Gordon01 wants to merge 1 commit intoconsole-rs:mainfrom
Open
Support of reading the is_tty status of stdin#200Gordon01 wants to merge 1 commit intoconsole-rs:mainfrom
is_tty status of stdin#200Gordon01 wants to merge 1 commit intoconsole-rs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the initial support of reading piped stdin.
This issue is mentioned multiple times here and in
dialoguer: #76 #35 console-rs/dialoguer#296 console-rs/dialoguer#170Most importantly, this PR adds the
Term.features().is_input_a_tty()method.I've added a new type
Ttywhich holds the statuses of all application streams. It encompasses the logic to detect the attendance of the terminal.It also contains
is_ttymoved from theTermwhich follows the old behavior, where only the output streams were considered.It's debatable, whether should we change the behavior of the
Term.is_term()method to also check the input stream attendance.This itself doesn't solve the problem with reading piped input, the next step would be updating
dialoguerto use the new methodis_input_a_tty(). I tried the following code and it works. The main drawback is that piped input can only be read once during the application's lifetime. So if the user has multiple inputs, the second and following will be an empty string.