Open
Conversation
Signed-off-by: jasonz <ksdpmx@gmail.com>
AkihiroSuda
reviewed
Mar 1, 2025
| } | ||
|
|
||
| excludeList := strings.Split(*excludes, " ") | ||
| excludeDirs := strings.Split(*excludedirs, " ") |
Member
There was a problem hiding this comment.
What if a file path contains a space?
Member
There was a problem hiding this comment.
Better to use https://pkg.go.dev/github.com/spf13/pflag#StringSlice
AkihiroSuda
reviewed
Mar 1, 2025
| func main() { | ||
| ppath := flag.String("path", ".", "project path") | ||
| excludes := flag.String("excludes", "vendor", "exclude folders") | ||
| excludedirs := flag.String("exclude-dirs", ".git .svn vendor", "exclude dirs matching with glob patterns") |
Member
There was a problem hiding this comment.
From the flag name it is not clear how this differs from excludes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There're some hardcoded directories and files excluded implicitly.
And sometimes we may need some kind of flexibility for specifing exclusions,
So here introducing two new opt-in flags:
-exclude-dirs-exclude-filesThe default behavior for these two flags aligns with the existing
-excludesfor backward compatiblity.And glob matching is supported, e.g.
./ltag -check -v -path ./test -exclude-dirs ".git .svn vendor image/module[abc]" -exclude-files "LICENSE MAINTAINERS OWNERS test/temp.go test/internal/foo*.go".-excludescan be deleted if breaking change is acceptable.