go.mod: preparation for renaming kunalkushwaha/ltag to containerd/ltag#18
Merged
AkihiroSuda merged 2 commits intocontainerd:masterfrom Mar 4, 2025
Merged
go.mod: preparation for renaming kunalkushwaha/ltag to containerd/ltag#18AkihiroSuda merged 2 commits intocontainerd:masterfrom
AkihiroSuda merged 2 commits intocontainerd:masterfrom
Conversation
alexandear
reviewed
Mar 3, 2025
go.mod
Outdated
| @@ -1,3 +1,3 @@ | |||
| module github.com/kunalkushwaha/ltag | |||
| module github.com/containerd/ltag | |||
There was a problem hiding this comment.
Maybe we should add also a deprecated comment. https://go.dev/ref/mod#go-mod-file-module-deprecation
Maintainers, see also https://appliedgo.net/spotlight/rename-a-public-module/
Member
Author
There was a problem hiding this comment.
ltag is just a dev tool and not widely used outside us, so no need to have a deprecation process
Member
There was a problem hiding this comment.
These are the usages https://github.com/search?type=code&q=kunalkushwaha%2Fltag. Since it has been in containerd/ltag for some time, I think we can do the migration.
AkihiroSuda
changed the title
alexandear
reviewed
Mar 3, 2025
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Relates to issue 17 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
dmcgowan
approved these changes
Mar 3, 2025
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to:
go install github.com/containerd/ltag@v0.2.5fails (module declares its path as: github.com/kunalkushwaha/ltag) #17