Add OnlyOS function allow matching any architecture#33
Merged
fuweid merged 1 commit intocontainerd:mainfrom Mar 31, 2026
Merged
Add OnlyOS function allow matching any architecture#33fuweid merged 1 commit intocontainerd:mainfrom
fuweid merged 1 commit intocontainerd:mainfrom
Conversation
Ensures that the same OS is matched but only considers architectures for compare. Signed-off-by: Derek McGowan <derek@mcg.dev>
Member
|
This will address containerd/containerd#13091 (comment) |
hsiangkao
approved these changes
Mar 31, 2026
fuweid
approved these changes
Mar 31, 2026
cpuguy83
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that the same OS is matched but only considers architectures for compare.
This comparison would be used for unpack cases where any hardware platform on a given OS could be unpacked. Currently containerd has a skip platform check option in the transfer service which is only intended to match any hardware platform. It would be better to have this matcher in the platforms library.