Add RunOptions.ValidExitCodes and --valid-exit-codes flag#6817
Open
akca wants to merge 4 commits intocontainers:mainfrom
Open
Add RunOptions.ValidExitCodes and --valid-exit-codes flag#6817akca wants to merge 4 commits intocontainers:mainfrom
akca wants to merge 4 commits intocontainers:mainfrom
Conversation
dosubot
Bot
added
the
size:M
Add support for treating specific non-zero exit codes as success in `buildah run`, aligning with BuildKit's Op_Exec.Meta.ValidExitCodes semantics. Signed-off-by: Fatih Akca <fatihakca5@gmail.com>
akca
force-pushed
the
opexec-validexitcodes
branch
from
ec415bc to
70db65d
Compare
| run_buildah 1 run $cid sh -c "exit 1" | ||
|
|
||
| # Exit 1 succeeds with --valid-exit-codes 0,1 | ||
| run_buildah run --valid-exit-codes 0,1 $cid sh -c "exit 1" |
Member
There was a problem hiding this comment.
can you add a verification that you got the right error on this call?
Contributor
Author
There was a problem hiding this comment.
Makes sense, just added
Member
|
In general, LGTM |
Signed-off-by: Fatih Akca <fatihakca5@gmail.com>
Signed-off-by: Fatih Akca <fatihakca5@gmail.com>
chroot isolation path prints "subprocess exited with status 1" unconditionally, so the output is never empty even on success. Signed-off-by: Fatih Akca <fatihakca5@gmail.com>
akca
force-pushed
the
opexec-validexitcodes
branch
from
05048b2 to
5b2c4c4
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
nalind
approved these changes
Apr 29, 2026
Member
nalind
left a comment
nalind
left a comment
There was a problem hiding this comment.
LGTM, thanks! Please squash these before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a new field
RunOptions.ValidExitCodesand a--valid-exit-codesCLI flag forbuildah runthat lets specific non-zero exit codes be treated as success, aligning with BuildKit'sOp_Exec.Meta.ValidExitCodes.How to verify it
Which issue(s) this PR fixes:
Fixes #6805
Special notes for your reviewer:
Does this PR introduce a user-facing change?