unshare: do not cache HomeDir() when HOME is set#789
Merged
Luap99 merged 1 commit intocontainers:mainfrom Apr 24, 2026
Merged
Conversation
mtrmac
approved these changes
Apr 24, 2026
Only cache the user.LookupId() fallback path, not the $HOME environment variable check. This allows tests that set a custom $HOME per test to work correctly, while still preserving the performance optimization for the slow NSS/LDAP lookup path. Closes: containers#787 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
unshare-always-honor-HOME
branch
from
c14faf6 to
522f9ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only cache the user.LookupId() fallback path, not the $HOME environment variable check. This allows tests that set a custom $HOME per test to work correctly, while still preserving the performance optimization for the slow NSS/LDAP lookup path.
Closes: #787