libnetwork: add route type field#802
Merged
mheon merged 2 commits intocontainers:mainfrom Apr 29, 2026
Merged
Conversation
Member
Author
6 tasks
Added in netavark in containers/netavark#1417 Needed for containers/podman#28230 The invalid gw test was somewhat broken, as the go type uses net.IP the parsing of the ip failed in the test and the ip was just left nil. This means the json marshal just sends an empty string to netavark and well that failed parsing in NV then. However now with the route type the gateway is optional an omitempty and therefore no longer is send to NV. Instead NV will no fail with a different error about the missing gateway for unicast routes. But because the other test checks that once already I rather remove the checks here as they do not really add value to do this for each network driver. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Member
|
LGTM, but still not a networking expert |
mtrmac
reviewed
Apr 29, 2026
Contributor
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
ACK (looking only at the structure of the PR, not the surrounding code), merge whenever appropriate.
mtrmac
reviewed
Apr 29, 2026
Contributor
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
@Luap99 , @ashley-cui : a LLM points out there is common/libnetwork/internal/util.ValidateRoutes which
- still requires a non-nil
Gateway - is dead code after #610
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
added
the
podman 6
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added in netavark in containers/netavark#1417
Needed for containers/podman#28230