crun exec: more verbose exec error message#2081
Open
kolyshkin wants to merge 1 commit intocontainers:mainfrom
Open
crun exec: more verbose exec error message#2081kolyshkin wants to merge 1 commit intocontainers:mainfrom
kolyshkin wants to merge 1 commit intocontainers:mainfrom
Conversation
Add the actual path we failed to exec into the error. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the error handling in exec_process_entrypoint to include the executable path in the error message. The reviewer suggests further improving the error message consistency by explicitly mentioning the container process in the log output.
|
|
||
| TEMP_FAILURE_RETRY (execv (exec_path, process->args)); | ||
| libcrun_fail_with_error (errno, "exec"); | ||
| libcrun_fail_with_error (errno, "exec `%s`", exec_path); |
There was a problem hiding this comment.
For consistency with other exec error messages in crun (e.g., in container_init), it would be clearer to make this error message more descriptive.
libcrun_fail_with_error (errno, "exec container process %s", exec_path);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the actual path we failed to exec into the error.