Refactor parser#169
Merged
giuseppe merged 6 commits intocontainers:mainfrom Apr 29, 2026
Merged
Conversation
giuseppe
force-pushed
the
refactor-parser
branch
2 times, most recently
from
4843957 to
a312988
Compare
Member
Author
|
@flouthoc PTAL |
Member
Author
|
@jnovy PTAL |
|
LGTM clean refactoring — the json_api.py abstraction is well-structured and the commits are nicely atomic. Minor observations:
|
Member
Author
yes I've verified that. I'll take care of the nits |
Move all YAJL-specific C code fragments (type names, macros, function calls) from sources.py and headers.py into a new json_api.py module. This makes it possible to switch the underlying JSON library by modifying json_api.py only, without touching the rest of the generator. The generated C code is byte-for-byte identical. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
The do/get_val/array_check/len/values/calloc block was duplicated identically across ObjectArrayHandler, PrimitiveArrayHandler, and BasicMapArrayHandler. Extract it into emit_array_parse_preamble(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
The if-OPT_GEN + gen_key + len setup + beautify_off + array_open + check_gen_status block was duplicated across ObjectArrayHandler, PrimitiveArrayHandler, and BasicMapArrayHandler. Extract it into emit_array_gen_preamble(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
StringType, BooleanPointerType, and NumericPointerType all manually inlined the free()/NULL= pattern instead of using the existing free_and_null() helper. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
BooleanPointerType and NumericPointerType had identical clone logic (calloc + NULL check + dereference copy), differing only in sizeof type. Extract into a shared helper. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
…en()
ObjectType, MapStringObjectType, and BasicMapType all had the same
if-OPT_GEN + gen_key + stat=gen_{type} + check_gen_status structure
in their emit_generate methods. Extract into a shared helper.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
refactor-parser
branch
from
a312988 to
015bb87
Compare
Member
Author
|
pushed a fixed version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some cleanups, more details in each commit