topology-aware: initial scheduling class support.#626
Open
klihub wants to merge 10 commits intocontainers:mainfrom
Open
topology-aware: initial scheduling class support.#626klihub wants to merge 10 commits intocontainers:mainfrom
klihub wants to merge 10 commits intocontainers:mainfrom
Conversation
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
klihub
force-pushed
the
devel/topology-aware/scheduling-classes
branch
from
091fe49 to
be49f4e
Compare
klihub
changed the title
askervin
reviewed
Feb 4, 2026
askervin
reviewed
Feb 4, 2026
askervin
approved these changes
Feb 4, 2026
Collaborator
askervin
left a comment
askervin
left a comment
There was a problem hiding this comment.
Looks very good to me. I trust your judgement in the only thing that I noticed and raised reviewing this.
Collaborator
Author
Well, although I'm glad to hear it, I myself not so much this time. I think it's a good idea to extend the eligibility for scheduling classes to at least Burstable and non-exclusive Guaranteed class containers, and perhaps even throwing in the per-QoS class default scheduling class I mentioned. |
klihub
force-pushed
the
devel/topology-aware/scheduling-classes
branch
from
be49f4e to
a5139db
Compare
Collaborator
Author
|
@askervin Okay, I reworked this a bit, adding
Per namespace scheduling classes take precedence over per Pod QoS class ones, and explicitly annotation scheduling classes take precedence over both. |
klihub
force-pushed
the
devel/topology-aware/scheduling-classes
branch
from
a5139db to
f7516fa
Compare
Add support for declaring known scheduling classes for the topology- aware policy. A scheduling class is a combination of Linux schduler policy and I/O priority parameters. It is represented using the same policy-agnostic data structure as used by the balloons policy. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Implement support for annotated assignment of containers to scheduling classes. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
devel/topology-aware/scheduling-classes
branch
from
f7516fa to
7d20aac
Compare
askervin
reviewed
Feb 6, 2026
test/e2e/policies.test-suite/topology-aware/n4c16/test17-scheduling-classes/code.var.sh
Outdated
Show resolved
Hide resolved
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
devel/topology-aware/scheduling-classes
branch
from
7d20aac to
8b16a99
Compare
Collaborator
Author
Well, they pass now... and this time they also properly fail if that typo is in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes: This PR is stacked on top of #618.
This patch series implements initial scheduling class support for the topology-aware policy. In particular, the PR