Skip to content

Ensure that APIError is thrown on failure to pull image#631

Merged
inknos merged 1 commit into
containers:mainfrom
simonbrauner:issue-301
Mar 30, 2026
Merged

Ensure that APIError is thrown on failure to pull image#631
inknos merged 1 commit into
containers:mainfrom
simonbrauner:issue-301

Conversation

@simonbrauner

@simonbrauner simonbrauner commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Fixes: #301

@inknos

inknos commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Quick look. I would add the GO PR as a reference in the commit body

@simonbrauner simonbrauner force-pushed the issue-301 branch 3 times, most recently from 3d90c4c to 604fb45 Compare March 4, 2026 15:23
@simonbrauner simonbrauner marked this pull request as ready for review March 4, 2026 15:24
@simonbrauner
Ensure that APIError is thrown on failure to pull image
6ffd5c7 
Podman part of the functionality implemented in
podman-container-tools/podman#28109

Fixes: containers#301

Signed-off-by: Šimon Brauner <sbrauner@redhat.com>
Honny1
Honny1 approved these changes Mar 5, 2026
View reviewed changes

@Honny1 Honny1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@Honny1

Honny1 commented Mar 5, 2026

Copy link
Copy Markdown
Member

PTAL @inknos

@inknos

inknos commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

LGTM, This needs to be merged after 5.8.0 though, since it's a breaking change for 6.0.0. We don't have a branching strategy in podman-py, but might be something considering just for 6.0.0. we should talk about it @Honny1 @jwhonce @simonbrauner

@Honny1

Honny1 commented Mar 6, 2026

Copy link
Copy Markdown
Member

This feels more like a fix for API error handling rather than a behavior change that is a breaking change. It should work with the current Podman version, though I haven't verified that myself.

@Honny1

Honny1 commented Mar 6, 2026

Copy link
Copy Markdown
Member

However, a branching strategy should exist.

@inknos

inknos commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

This feels more like a fix for API error handling rather than a behavior change that is a breaking change. It should work with the current Podman version, though I haven't verified that myself.

It will raise for status, which might be disruptive. I am ok to merge it after the next tag, however, if we ever need to do 5.8.1 after 6.0.0 branching will be needed

@TomSweeneyRedHat

TomSweeneyRedHat commented Mar 18, 2026

Copy link
Copy Markdown
Member

LGTM
@inknos I'll trust you to hit the merge button when the timing is right on this one.

@inknos

inknos commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Sure. I'll hit merge after the git tag

@inknos inknos merged commit 7e66d02 into containers:main Mar 30, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Honny1 Honny1 Honny1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pulling a wrong image doesn't raise any error.

4 participants

@simonbrauner @inknos @Honny1 @TomSweeneyRedHat