Add ssh parameter support for image builds#642
Open
sowmya-sl wants to merge 1 commit into
Open
Conversation
Contributor
|
@sowmya-sl thanks for the PR, please sign your commit as DCO bot says |
sowmya-sl
force-pushed
the
add-ssh-params
branch
from
b91b1c7 to
23b0c67
Compare
Contributor
|
/packit retest-failed |
inknos
reviewed
Apr 10, 2026
Author
|
@inknos Let me know if anything needs to be added from the server side. |
Author
|
/packit retest-failed |
Honny1
reviewed
Apr 29, 2026
| manifest (str) - add the image to the specified manifest list. | ||
| Creates manifest list if it does not exist. | ||
| secrets (list[str]) - Secret files/envs to expose to the build | ||
| ssh (list[str]) - SSH agent socket or keys to expose to the build |
Member
There was a problem hiding this comment.
I would add an example of how content should look, or refer that content should look like podman build --ssh.
| params["secrets"] = json.dumps(kwargs.get("secrets")) | ||
|
|
||
| if "ssh" in kwargs: | ||
| params["ssh"] = json.dumps(kwargs.get("ssh")) |
Member
There was a problem hiding this comment.
Non-blocking: What if kwargs.get("ssh") returns an empty array?
Allow passing SSH agent sockets or keys to the build API, similar to the existing secrets parameter support. Review comments: - Add usage examples and reference to podman build --ssh in the ssh parameter docstring Signed-off-by: sowmya-sl <lsowmyanarayanan@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
@sowmya-sl thanks @Honny1 I think a change is needed in podman like this. it's just a POC, what do you think? |
Member
I think yes. |
inknos
added a commit
to inknos/podman
that referenced
this pull request
Jun 9, 2026
Pass SSH agent sockets or keys through the build API, mirroring the existing secrets parameter support. - Add `ssh` query parameter to the build endpoint - Parse and move SSH key files out of the build context (same pattern as secrets) - Wire SSHSources into buildah CommonBuildOptions - Add client-side SSH key file handling in Go bindings - Add e2e test for --ssh flag with key file Related: containers/podman-py#602 Related: containers/podman-py#642 Signed-off-by: Nicola Sella <nsella@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow passing SSH agent sockets or keys to the build API, similar to the existing secrets parameter support.
Fixes: #602